Provide a way to configure the RunJobFlowRequest #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -19,7 +19,8 @@ class Emr private(credentials: Option[AWSCredentials]) { | |||
|
|
|||
| def this(knownCredentials: AWSCredentials) = this(Some(knownCredentials)) | |||
|
|
|||
| def run(flow: JobFlow)(implicit config: ClusterConfig): String = { | |||
| def run(flow: JobFlow, configureRequest: RunJobFlowRequest => RunJobFlowRequest = identity) | |||
| (implicit config: ClusterConfig): String = { | |||
There was a problem hiding this comment.
maybe provide a backwards compatible API here?
def run(flow :JobFlow)(implicit config: ClusterConfig): String =
run(flow, identity[RunJobFlowRequest])(config)There was a problem hiding this comment.
Good point but it is backwards compatible due to the default value (which basically does nothing)
There was a problem hiding this comment.
oh oops didn't see the default value, good call :)
ogrodnek
added a commit
that referenced
this pull request
Feb 3, 2016
Provide a way to configure the RunJobFlowRequest
|
Thanks for the commit! |
|
Okay, in theory a release with this change should show up in Maven central as com.bizo#spark-plug_2.10#1.2.6. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ads a back door for when spark-plug is not up to date with the features provided by the emr sdk.